Skip to content

Remove Run 1-3 and disable Phase 2 RelVal workflows that read existing non-RAW files#50954

Merged
ftenchini merged 1 commit into
cms-sw:masterfrom
makortel:evoIntegrationRelVal
Jun 5, 2026
Merged

Remove Run 1-3 and disable Phase 2 RelVal workflows that read existing non-RAW files#50954
ftenchini merged 1 commit into
cms-sw:masterfrom
makortel:evoIntegrationRelVal

Conversation

@makortel

@makortel makortel commented May 15, 2026

Copy link
Copy Markdown
Contributor

PR description:

This PR is part of integrating the changes from the EVOLUTION_X branch to the master branch in CMSSW_20_0_X. It removes Run 1-3 RelVal workflows that read existing non-RAW files that will not be redable in 20_0_X and onwards. Similar Phase 2 workflows are disabled by commenting them out, because they will likely be enabled in the future after their non-RAW input files have been remade.

Following the strategy agreed in ORP 2026-05-05, it is opened already now to allow it to be reviewed such that it could be merged quickly when the master branch moves to 20_0_X.

Note unusual integration: This PR will be merged in 20_0_X regardless of the review status unless major flaws come up during the review and they have not been addressed.

Resolves cms-sw/framework-team#2226

PR validation:

None beyond the tests of EVOLUTION_X IBs

@cmsbuild

cmsbuild commented May 15, 2026

Copy link
Copy Markdown
Contributor

cms-bot internal usage

@makortel

Copy link
Copy Markdown
Contributor Author

hold

Until master branch moves to 20_0_X

@cmsbuild cmsbuild added the hold label May 15, 2026
@cmsbuild

Copy link
Copy Markdown
Contributor

@cmsbuild

Copy link
Copy Markdown
Contributor

Pull request has been put on hold by @makortel
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

@cmsbuild

Copy link
Copy Markdown
Contributor

A new Pull Request was created by @makortel for master.

It involves the following packages:

  • Configuration/PyReleaseValidation (pdmv)

@AdrianoDee, @DickyChant, @antoniovagnerini, @cmsbuild, @kfjack, @miquork, @sroychow can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @fabiocos, @slomeo this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@makortel

Copy link
Copy Markdown
Contributor Author

@cms-sw/pdmv-l2 If any of the Run 1-3 specific workflows are worth of keeping for Phase 2, we could also remove them now instead of commenting them out if you'd prefer.

@makortel

Copy link
Copy Markdown
Contributor Author

@cmsbuild, please test with cms-sw/cms-bot#2753

This PR should be testable after disabling few workflows on the cms-bot side (not very useful in the end, but let's demonstrate nevertheless).

@cmsbuild

Copy link
Copy Markdown
Contributor

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fec7a5/53284/summary.html
COMMIT: e584277
CMSSW: CMSSW_17_0_X_2026-05-15-1100/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/50954/53284/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@makortel

Copy link
Copy Markdown
Contributor Author

@cms-sw/pdmv-l2 Do you have any comments?

@makortel

makortel commented Jun 4, 2026

Copy link
Copy Markdown
Contributor Author

See cms-sw/cms-bot#2753 that is used temporarily for testing of #50968 with this PR and #50953, and cms-sw/cms-bot#2765 for an update that is intended to be merged.

@AdrianoDee

AdrianoDee commented Jun 5, 2026 via email

Copy link
Copy Markdown
Contributor

@cmsbuild

cmsbuild commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

Milestone for this pull request has been moved to CMSSW_20_0_X. Please open a backport if it should also go in to CMSSW_17_0_X.

@cmsbuild cmsbuild modified the milestones: CMSSW_17_0_X, CMSSW_20_0_X Jun 5, 2026
@makortel makortel changed the title [20_0_X] Remove Run 1-3 and disable Phase 2 RelVal workflows that read existing non-RAW files Remove Run 1-3 and disable Phase 2 RelVal workflows that read existing non-RAW files Jun 5, 2026
@makortel

makortel commented Jun 5, 2026

Copy link
Copy Markdown
Contributor Author

unhold

master branch is now in 20_0_X

@cmsbuild

cmsbuild commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @mandrenguyen, @ftenchini (and backports should be raised in the release meeting by the corresponding L2)

@ftenchini

Copy link
Copy Markdown
Contributor

+1

@ftenchini

Copy link
Copy Markdown
Contributor

Please test

@cmsbuild

cmsbuild commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

-1

Failed Tests: RelVals
Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fec7a5/53700/summary.html
COMMIT: b688d7c
CMSSW: CMSSW_17_0_X_2026-06-05-1100/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/50954/53700/install.sh to create a dev area with all the needed externals and cmssw changes.

Failed RelVals

ValueError: Undefined workflows: 10224.0, 250202.181, 25202.0

@ftenchini ftenchini merged commit fbdb918 into cms-sw:master Jun 5, 2026
8 of 9 checks passed
@makortel makortel deleted the evoIntegrationRelVal branch June 8, 2026 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PR to disable RelVal workflows reading non-RAW files

4 participants